Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Security Vulnerability- Remote Code execution #6036

Closed
senthilengg opened this issue Aug 7, 2016 · 15 comments
Closed

Potential Security Vulnerability- Remote Code execution #6036

senthilengg opened this issue Aug 7, 2016 · 15 comments
Labels
bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@senthilengg
Copy link

senthilengg commented Aug 7, 2016

Any idea @magento-team

@senthilengg senthilengg changed the title Potential Security Vulnerability Potential Security Vulnerability- Remote Code execution Aug 7, 2016
@andimov
Copy link
Contributor

andimov commented Aug 8, 2016

@senthilengg
Thank you for reporting!
To allow us to research the issue, please, provide format this issue according to the Issue reporting guidelines

@hostep
Copy link
Contributor

hostep commented Aug 8, 2016

Shouldn't security vulnerabilities be reported to [email protected] instead of out in the open? Or am I mistaken? @piotrekkaminski?

@commcad
Copy link

commcad commented Aug 8, 2016

+1

Certainly has my vote for this to be removed asap. Surely wouldn't want Mr Cracka's gang to see this that's for sure.

Sec rep to [email protected] with IMPORTANCE set to !

@andimov andimov added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report and removed Progress: needs update labels Aug 8, 2016
@commcad
Copy link

commcad commented Aug 8, 2016

@senthilengg

Importance of having/forcing Magento 2.1 onto HTTPS is paramount. That would have cancelled customers risks by alerting SSL issues but would not have prevented the exploit itself. For now anyway.

@andimov
Copy link
Contributor

andimov commented Aug 8, 2016

@senthilengg
We've created internal ticket MAGETWO-56581 to investigate it.
Please, remove details from the description.

@commcad
Copy link

commcad commented Aug 8, 2016

And replace with this:

$MAGE_ROOT = /pub (!!!)(for nginx, ps: apache is dead man)

$ php bin/magento deploy:mode:set production
$ sudo chown -R $USER:www-data .
$ find . -type d -exec chmod 770 {} ; && find . -type f -exec chmod 660 {} ;
$ find var vendor pub/static app/etc var/generation var/di var/view_preprocessed -type f -exec chmod u-w {} ;
$ find var vendor pub/static app/etc var/generation var/di var/view_preprocessed -type d -exec chmod u-w {} ;
$ chmod o-rwx app/etc/env.php
$ chmod u+x bin/magento

@senthilengg
Copy link
Author

@andimov I have removed the description as you requested. Let me know the update ASAP.

Any suggestions other than SSL ?

@commcad
Copy link

commcad commented Aug 8, 2016

@senthilengg Yes; NGINX + REDIS running on unix socket set with 700 perms + cache db credentials (strong U/P)

In reality, if you'd ask me; I'd say the only way is to get off the Internet e.g. pull the plug.

Literally mate :/

@commcad
Copy link

commcad commented Aug 8, 2016

Oh, one other thing (normally this deter the worst of the worsts!):

::Hide Server Signature of Nginx & PHP::

$ curl -I https://www.mydomain.com
^ see if the server signatures are listed publicly!

$ sudo nano /etc/nginx/nginx.conf
uncomment server_tokens off;
$ sudo service nginx restart

$ sudo nano /etc/php/7.0/cli/php.ini
Set expose_php = Off
$ sudo service php7.0-fpm restart

Hide NGINX server details
sudo apt-get install nginx-extras
$ sudo nano /etc/nginx/nginx.conf
add line: more_set_headers 'Server: whatever-wwwsrv-name-here';
$ sudo service nginx restart

$ sudo reboot
Test!
$ curl -I https://www.mydomain.com

@piotrekkaminski
Copy link
Contributor

@senthilengg I would appreciate if you could reach out to me directly peter (at) magento.com with more details - version, anything in the logs etc.

@magenx
Copy link

magenx commented Aug 11, 2016

@senthilengg how did you find it?

@senthilengg
Copy link
Author

@magenxI have removed the details intentionally coz it should be maintained confidential as per magento guys request. So probably you have to wait until we get a patch.

@magenx
Copy link

magenx commented Aug 11, 2016

im asking how did you find it, you search in the files for something specific or it was an error in the browser console, etc...

@senthilengg
Copy link
Author

Going to be an year now with no update. @magento-team

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 11, 2017
@okorshenko
Copy link
Contributor

The issue has been investigated. Closing as non-issue.

@magento magento locked and limited conversation to collaborators Nov 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

8 participants