Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price indexer running for multiple hours with 2.1 million products #38147

Closed
1 of 5 tasks
ioweb-gr opened this issue Nov 3, 2023 · 10 comments
Closed
1 of 5 tasks

Price indexer running for multiple hours with 2.1 million products #38147

ioweb-gr opened this issue Nov 3, 2023 · 10 comments
Assignees
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.5-p2 Indicates original Magento version for the Issue report.

Comments

@ioweb-gr
Copy link
Contributor

ioweb-gr commented Nov 3, 2023

Preconditions and environment

  • 2.4.5-p2

Steps to reproduce

We have created a website with 45974 configurable products and a total of 2.1 million products with their variations + simple products

Reindexing process crashed in scheduled mode and for some reasons and we need to reindex them fully.

Unexpectedly though the reindex process runs for too many hours for the price indexer and this leads to products not displaying in the frontend as in order to reindex the catalog search index and the category products index, the price index must run as well but it takes too long.

Now our frontend is missing products

Is magento even able to handle the 2.1m products? What can I do to make it run faster? Changing the batch size has no effect whatsoever, the speed is horribly slow.

Expected result

All indexers run fast.

Actual result

Reindexing is slow.

Additional information

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Nov 3, 2023

Hi @ioweb-gr. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.5-p2 Indicates original Magento version for the Issue report. label Nov 6, 2023
@hostep
Copy link
Contributor

hostep commented Nov 19, 2023

Not sure if it is the same issue, but there is a bug in Magento 2.4.x (not in 2.3.x) with the indexers where the partial indexer could loop unnecessarily many times over the same entities to index and sometimes even skip indexing entities it should reindex.
That was fixed in #36155 (which is supposed to be included in Magento 2.4.7)

@amouri82
Copy link

Hello,
@hostep there is a patch to fix this issue or not yet ? We are facing the same problem and can't wait next release to fix it. Thanks

@hostep
Copy link
Contributor

hostep commented Nov 23, 2023

@amouri82: Start from the diff of the PR: https://patch-diff.githubusercontent.com/raw/magento/magento2/pull/36155.diff
And see if you can apply that as a patch (you'll have to convert the paths so you can apply it to a composer installation).

We do have a patch of our own, but it was based on an older version of the PR (some extra changes made it in after we created our patch). So I'm not sure if I should share it here as it is a bit outdated.

@amouri82
Copy link

@hostep Thanks you for your replay and the diff of the PR. I will try to create owr own patch and share it if works.
Thanks.

@engcom-Dash
Copy link
Contributor

Hi @ioweb-gr

Thanks for reporting and collaboration.

As per the above comments the issue is fixed in #36155 in Magento 2.4.7

Please try to reproduce the issue in magneto 2.4.7 and let us know if you still face the issue.

Thanks

@engcom-Dash engcom-Dash self-assigned this Jan 8, 2024
Copy link

m2-assistant bot commented Jan 8, 2024

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@engcom-Dash engcom-Dash added the Issue: needs update Additional information is require, waiting for response label Jan 8, 2024
Copy link

m2-assistant bot commented Jan 19, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo
Copy link
Contributor

Hi @ioweb-gr,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance with 1M products and the issue is not reproducible.Kindly refer the screenshots.

Screenshot 2024-11-12 at 13 54 58 Screenshot 2024-11-12 at 16 11 31

Kindly recheck the issue in Latest 2.4-develop instance and elaborate the steps to reproduce if the issue is still reproducible.

Thanks.

@ioweb-gr
Copy link
Contributor Author

Actually I lost track of htis issue. It's indeed resolved in 2.4.7-p2 as far as I can see. I never experienced again such long running times for price indexer so we can close it for now. I'll reopen a new issue if I bump into it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.5-p2 Indicates original Magento version for the Issue report.
Projects
None yet
Development

No branches or pull requests

5 participants