Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price indexers make queries flood MariaDb until the site drops (Please reopen #36667) #36780

Closed
ioweb-gr opened this issue Jan 25, 2023 · 6 comments
Assignees
Labels
Issue: needs update Additional information is require, waiting for response

Comments

@ioweb-gr
Copy link
Contributor

ioweb-gr commented Jan 25, 2023

Today I faced this issue again and caught it really early and briefly I noticed that the holdup came when the indexer was renaming price tables to _outdated or something like this I'm assuming to move the replica table into it's place.

During these rename queries, the other queries started piling up and the system dropped.

On my system the price tables are fairly large now.

image

So renaming a table like this would most likely take considerable time.

This is a followup on #36667

@m2-assistant
Copy link

m2-assistant bot commented Jan 25, 2023

Hi @ioweb-gr. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@ioweb-gr
Copy link
Contributor Author

Normally rename shouldn't take that long to execute unless the table is locked. I think there are multiple locks placed on the tables during price indexing which cause deadlock and that's why rename gets stuck there. When the rename got finished, all other queries finished fast.
Is it possible the table is locked both by the rename process and the scheduled indexers processing prices at the same time causing the deadlock?

We're really buffled as to what is causing these random downtimes due to this and eliminated all other factors we could

@engcom-Dash engcom-Dash self-assigned this Feb 8, 2023
@m2-assistant
Copy link

m2-assistant bot commented Feb 8, 2023

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@engcom-Dash
Copy link
Contributor

Hi @ioweb-gr ,

Kindly Provide Additional Information About this issue...It's very easy to proceed further.So Kindly Update below information
1.Steps to reproduce
2.Precondition
3.Actual result
4.Expected Result.

Thanks.

@engcom-Dash engcom-Dash added the Issue: needs update Additional information is require, waiting for response label Feb 20, 2023
@ioweb-gr
Copy link
Contributor Author

@engcom-Dash The problem is I can't find the proper steps to reproduce. Could you please provide any input as where those queries could be coming from so we can add some logs perhaps that can help us find the steps to replicate?

@engcom-Dash
Copy link
Contributor

engcom-Dash commented Feb 22, 2023

Hi @ioweb-gr ,

With all due respect, it seems to be a duplicate issue of ticket number 36667 Hence We are closing this ticket and we will follow the parent issue (#36667).

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: needs update Additional information is require, waiting for response
Projects
None yet
Development

No branches or pull requests

2 participants