Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento 2.3: Import fails if configurable attribute has an equal sign in its value #25188

Closed
viniciusfabri opened this issue Oct 21, 2019 · 4 comments
Assignees
Labels
Component: ImportExport Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Partner: Youwe

Comments

@viniciusfabri
Copy link
Member

viniciusfabri commented Oct 21, 2019

Preconditions (*)

  1. Magento 2.3.2 (2.3-develop also works) - PHP 7.1.26
  2. Sample data Installer

Steps to reproduce (*)

  1. Change one of the attributes used by the configurable products (Size for instance) to have an = sign in its value
  2. Export a configurable product that uses this attribute
  3. Try to import the CSV from the previous step

Expected result (*)

  1. Product should be imported correctly

Actual result (*)

  1. Product import fails

Description

This happens because when Magento is creating the product variations, it uses the equal sign as a separator, but if the attribute value has an equal sign in it, it breaks. We fixed this by adding a limit of '2' to the explode calls in these lines:
https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/ConfigurableImportExport/Model/Import/Product/Type/Configurable.php#L576
https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/ConfigurableImportExport/Model/Import/Product/Type/Configurable.php#L637

@m2-assistant
Copy link

m2-assistant bot commented Oct 21, 2019

Hi @viniciusfabri. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@viniciusfabri do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Oct 21, 2019
@dhoang89 dhoang89 self-assigned this Oct 21, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 21, 2019

Hi @dhoang89. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!


@dhoang89
Copy link

@magento I'm working on it

@VladimirZaets
Copy link
Contributor

@VladimirZaets VladimirZaets added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Jan 17, 2020
This was referenced May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: ImportExport Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Partner: Youwe
Projects
None yet
Development

No branches or pull requests

4 participants