Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect payment method translation in order emails #23333

Closed
arendarenko opened this issue Jun 20, 2019 · 12 comments
Closed

Incorrect payment method translation in order emails #23333

arendarenko opened this issue Jun 20, 2019 · 12 comments
Assignees
Labels
Component: Store Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@arendarenko
Copy link
Contributor

Preconditions (*)

  1. Magento 2.2.8
  2. Default sales email templates is used

Steps to reproduce (*)

  1. Create website with different locale than en_US (for example: fr_FR)
  2. Enable "Check / Money" order payment method for French website and translate it in into "Chèque / Argent"
  3. Flush cache
  4. Create new order in French store view
  5. Create shipment for it and set checkbox "Email Copy of Shipment" checked
  6. Create credit memo for it and set checkbox "Email Copy of Credit Memo" checked

Expected result (*)

  1. Customer will receive shipment and credit memo emails where in Payment Method area will be "Chèque / Argent", like it was in New order email

Actual result (*)

  1. Customer receiving shipment and credit memo emails with "Check / Money" in Payment Method area
@m2-assistant
Copy link

m2-assistant bot commented Jun 20, 2019

Hi @alexeya-ven. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@alexeya-ven do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jun 20, 2019
@magento magento deleted a comment from m2-assistant bot Jun 20, 2019
@engcom-Bravo engcom-Bravo self-assigned this Jun 20, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jun 20, 2019

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo
Copy link
Contributor

Hello @alexeya-ven. Would You please tell us what exactly You did in order to get "Check / Money Order" translated to "Chèque / Argent". Thank You.

@engcom-Bravo
Copy link
Contributor

@alexeya-ven You did it via Configuration right?

@engcom-Bravo
Copy link
Contributor

Also @alexeya-ven, it is most likely You mean You were creating those shipments and credit memos wile the default site was not that one with fr_FR locale. Please tell us is it so or not, as in Your Steps to Reproduce all of these things are not reflected or are called somewhat incorrectly (for example to change the name of the payment method in the Configuration for a particular website or store view is usually referred to as set another name but not to as translate). If everything is just as we think we can confirm the issue, but if it's not, then we are not able to reproduce it and so will need Your help in order to obtain the reproduction and to be able to confirm the issue.

@arendarenko
Copy link
Contributor Author

Hi @engcom-Bravo
The issue is happens when you have two websites with different locales - en_US (which is default) and fr_FR, and creating credit memo / shipment / invoice in orders which is placed in fr_FR website. In this cases Magento didn't emulate order store view, but uses default. Thats why payment method block in order email didn't translates correctly.

@engcom-Bravo
Copy link
Contributor

Thank You @alexeya-ven for Your reply. Then it seems everything is just as we think. But could You please confirm that You made the name of "Check / Money" look like "Chèque / Argent" in the following way:
ChMO
Thank You.

@arendarenko
Copy link
Contributor Author

@engcom-Bravo yes, we're talking about exactly the same case.

@engcom-Bravo engcom-Bravo added Component: Store Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release and removed Progress: needs update labels Jun 24, 2019
@engcom-Bravo
Copy link
Contributor

Making different locales for different sites are redundant.

@engcom-Bravo engcom-Bravo added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jun 24, 2019
@ghost ghost unassigned engcom-Bravo Jun 24, 2019
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jun 24, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-17759, MC-17760 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team
Copy link
Contributor

Hi @alexeya-ven. Thank you for your report.
The issue has been fixed in #23338 by @alexeya-ven in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.3 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jun 26, 2019
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jul 9, 2019
@magento-engcom-team
Copy link
Contributor

Hi @alexeya-ven. Thank you for your report.
The issue has been fixed in #23438 by @ihor-sviziev in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.10 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Store Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

3 participants