From 17bd44f2368d4bb8714a19803a2ac8461344f97a Mon Sep 17 00:00:00 2001
From: Sumesh P <sumesh.p@globallogic.com>
Date: Tue, 12 Dec 2023 18:18:16 +0530
Subject: [PATCH 1/2] LYNX-303: Added  in storeConfig graphql query

---
 .../Magento/QuoteGraphQl/etc/graphql/di.xml   |  1 +
 .../Magento/QuoteGraphQl/etc/schema.graphqls  |  1 +
 .../Quote/GetMaxItemsInOrderSummaryTest.php   | 57 +++++++++++++++++++
 3 files changed, 59 insertions(+)
 create mode 100644 dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/GetMaxItemsInOrderSummaryTest.php

diff --git a/app/code/Magento/QuoteGraphQl/etc/graphql/di.xml b/app/code/Magento/QuoteGraphQl/etc/graphql/di.xml
index e07efec5a8e4d..a7339b82fccd0 100644
--- a/app/code/Magento/QuoteGraphQl/etc/graphql/di.xml
+++ b/app/code/Magento/QuoteGraphQl/etc/graphql/di.xml
@@ -65,6 +65,7 @@
             <argument name="extendedConfigData" xsi:type="array">
                 <item name="is_guest_checkout_enabled" xsi:type="string">checkout/options/guest_checkout</item>
                 <item name="is_one_page_checkout_enabled" xsi:type="string">checkout/options/onepage_checkout_enabled</item>
+                <item name="max_items_in_order_summary" xsi:type="string">checkout/options/max_items_display_count</item>
             </argument>
         </arguments>
     </type>
diff --git a/app/code/Magento/QuoteGraphQl/etc/schema.graphqls b/app/code/Magento/QuoteGraphQl/etc/schema.graphqls
index 1c5c6c4e7710d..cbff57a333a42 100644
--- a/app/code/Magento/QuoteGraphQl/etc/schema.graphqls
+++ b/app/code/Magento/QuoteGraphQl/etc/schema.graphqls
@@ -445,4 +445,5 @@ enum CartUserInputErrorType {
 type StoreConfig {
     is_guest_checkout_enabled: Boolean @doc(description: "Extended Config Data - checkout/options/guest_checkout")
     is_one_page_checkout_enabled: Boolean @doc(description: "Extended Config Data - checkout/options/onepage_checkout_enabled")
+    max_items_in_order_summary: Int @doc(description: "Extended Config Data - checkout/options/max_items_display_count")
 }
diff --git a/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/GetMaxItemsInOrderSummaryTest.php b/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/GetMaxItemsInOrderSummaryTest.php
new file mode 100644
index 0000000000000..40886b4a95197
--- /dev/null
+++ b/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/GetMaxItemsInOrderSummaryTest.php
@@ -0,0 +1,57 @@
+<?php
+/**
+ * Copyright 2023 Adobe
+ * All Rights Reserved.
+ *
+ * NOTICE: All information contained herein is, and remains
+ * the property of Adobe and its suppliers, if any. The intellectual
+ * and technical concepts contained herein are proprietary to Adobe
+ * and its suppliers and are protected by all applicable intellectual
+ * property laws, including trade secret and copyright laws.
+ * Dissemination of this information or reproduction of this material
+ * is strictly forbidden unless prior written permission is obtained from
+ * Adobe.
+ */
+declare(strict_types=1);
+
+namespace Magento\GraphQl\Quote;
+
+use Magento\Framework\DataObject;
+use Magento\TestFramework\Fixture\Config;
+use Magento\TestFramework\TestCase\GraphQlAbstract;
+
+/**
+ * Test for getting max_items_in_order_summary from storeConfig query
+ */
+class GetMaxItemsInOrderSummaryTest extends GraphQlAbstract
+{
+    private const MAX_ITEMS_TO_DISPLAY = 5;
+
+    #[
+        Config('checkout/options/max_items_display_count', self::MAX_ITEMS_TO_DISPLAY)
+    ]
+    public function testGetMaxItemsInOrderSummary()
+    {
+        $query = $this->getQuery();
+        $response = $this->graphQlMutation($query);
+        $responseDataObject = new DataObject($response);
+
+        self::assertEquals(self::MAX_ITEMS_TO_DISPLAY, $responseDataObject->getData('storeConfig/max_items_in_order_summary'));
+    }
+
+    /**
+     * Create storeConfig query
+     *
+     * @return string
+     */
+    private function getQuery(): string
+    {
+        return <<<QUERY
+{
+  storeConfig {
+    max_items_in_order_summary
+  }
+}
+QUERY;
+    }
+}

From a567bc894f0e18d139bcad563bbc56cf20f242c8 Mon Sep 17 00:00:00 2001
From: Sumesh P <sumesh.p@globallogic.com>
Date: Tue, 12 Dec 2023 19:38:53 +0530
Subject: [PATCH 2/2] LYNX-303: Updated storeConfig test

---
 .../Quote/GetMaxItemsInOrderSummaryTest.php   | 57 -------------------
 .../GraphQl/Quote/StoreConfigResolverTest.php |  5 ++
 2 files changed, 5 insertions(+), 57 deletions(-)
 delete mode 100644 dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/GetMaxItemsInOrderSummaryTest.php

diff --git a/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/GetMaxItemsInOrderSummaryTest.php b/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/GetMaxItemsInOrderSummaryTest.php
deleted file mode 100644
index 40886b4a95197..0000000000000
--- a/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/GetMaxItemsInOrderSummaryTest.php
+++ /dev/null
@@ -1,57 +0,0 @@
-<?php
-/**
- * Copyright 2023 Adobe
- * All Rights Reserved.
- *
- * NOTICE: All information contained herein is, and remains
- * the property of Adobe and its suppliers, if any. The intellectual
- * and technical concepts contained herein are proprietary to Adobe
- * and its suppliers and are protected by all applicable intellectual
- * property laws, including trade secret and copyright laws.
- * Dissemination of this information or reproduction of this material
- * is strictly forbidden unless prior written permission is obtained from
- * Adobe.
- */
-declare(strict_types=1);
-
-namespace Magento\GraphQl\Quote;
-
-use Magento\Framework\DataObject;
-use Magento\TestFramework\Fixture\Config;
-use Magento\TestFramework\TestCase\GraphQlAbstract;
-
-/**
- * Test for getting max_items_in_order_summary from storeConfig query
- */
-class GetMaxItemsInOrderSummaryTest extends GraphQlAbstract
-{
-    private const MAX_ITEMS_TO_DISPLAY = 5;
-
-    #[
-        Config('checkout/options/max_items_display_count', self::MAX_ITEMS_TO_DISPLAY)
-    ]
-    public function testGetMaxItemsInOrderSummary()
-    {
-        $query = $this->getQuery();
-        $response = $this->graphQlMutation($query);
-        $responseDataObject = new DataObject($response);
-
-        self::assertEquals(self::MAX_ITEMS_TO_DISPLAY, $responseDataObject->getData('storeConfig/max_items_in_order_summary'));
-    }
-
-    /**
-     * Create storeConfig query
-     *
-     * @return string
-     */
-    private function getQuery(): string
-    {
-        return <<<QUERY
-{
-  storeConfig {
-    max_items_in_order_summary
-  }
-}
-QUERY;
-    }
-}
diff --git a/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/StoreConfigResolverTest.php b/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/StoreConfigResolverTest.php
index 3e980696b530a..0dbf16957ffed 100644
--- a/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/StoreConfigResolverTest.php
+++ b/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/StoreConfigResolverTest.php
@@ -17,9 +17,12 @@
  */
 class StoreConfigResolverTest extends GraphQlAbstract
 {
+    private const MAX_ITEMS_TO_DISPLAY = 5;
+
     #[
         ConfigFixture(Data::XML_PATH_GUEST_CHECKOUT, true, ScopeInterface::SCOPE_STORE, 'default'),
         ConfigFixture('checkout/options/onepage_checkout_enabled', true, ScopeInterface::SCOPE_STORE, 'default'),
+        ConfigFixture('checkout/options/max_items_display_count', self::MAX_ITEMS_TO_DISPLAY)
     ]
     public function testGetStoreConfig(): void
     {
@@ -29,6 +32,7 @@ public function testGetStoreConfig(): void
   storeConfig {
     is_guest_checkout_enabled,
     is_one_page_checkout_enabled,
+    max_items_in_order_summary
   }
 }
 QUERY;
@@ -47,5 +51,6 @@ private function validateStoreConfig(
     ): void {
         $this->assertTrue($responseConfig['is_guest_checkout_enabled']);
         $this->assertTrue($responseConfig['is_one_page_checkout_enabled']);
+        $this->assertEquals(self::MAX_ITEMS_TO_DISPLAY, $responseConfig['max_items_in_order_summary']);
     }
 }