Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Remove extra quotation sign #686

Closed
TomashKhamlai opened this issue May 8, 2019 · 2 comments
Closed

Remove extra quotation sign #686

TomashKhamlai opened this issue May 8, 2019 · 2 comments
Assignees
Labels
bug Something isn't working Component: CustomerGraphQl Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers

Comments

@TomashKhamlai
Copy link
Contributor

TomashKhamlai commented May 8, 2019

Preconditions (*)

  1. No preconditions

Steps to reproduce (*)

  1. No steps

Expected result (*)

  1. IsEmailAvailable.php#L47
throw new GraphQlInputException(__('Email must be specified'));
  1. UpdateCustomerAddress.php#L73
throw new GraphQlInputException(__('Address "id" value must be specified'));
  1. UpdateCustomerAddress.php#L77
throw new GraphQlInputException(__('"input" value must be specified'));

Actual result (*)

  1. IsEmailAvailable.php#L47
throw new GraphQlInputException(__('"Email should be specified'));
  1. UpdateCustomerAddress.php#L73
throw new GraphQlInputException(__('Address "id" value should be specified'));
  1. UpdateCustomerAddress.php#L77
throw new GraphQlInputException(__('"input" value should be specified'));
@TomashKhamlai TomashKhamlai added bug Something isn't working good first issue Good for newcomers Contribution Day Tickets is good for start on Contribution Day Component: CustomerGraphQl labels May 8, 2019
@TomashKhamlai
Copy link
Contributor Author

@naydav, please set estimation points.

@naydav naydav added this to the Release: 2.3.3 milestone May 8, 2019
@naydav naydav removed their assignment May 8, 2019
@osrecio osrecio self-assigned this May 9, 2019
@naydav
Copy link
Contributor

naydav commented May 27, 2019

#695

@naydav naydav closed this as completed May 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Component: CustomerGraphQl Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants