Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MFTF] User locates preview image in the Media Gallery #446

Closed
filmaj opened this issue Sep 23, 2019 · 5 comments
Closed

[MFTF] User locates preview image in the Media Gallery #446

filmaj opened this issue Sep 23, 2019 · 5 comments
Labels
MFTF tests MFTF tests coverage

Comments

@filmaj
Copy link
Contributor

filmaj commented Sep 23, 2019

Description

Implement MFTF test to cover scenario: "User locates preview image in the Media Gallery" (story 27, #329)

Preconditions

  1. Admin User is logged into Admin Panel
  2. User signs into Adobe IMS

Test steps

  1. Open Adobe Stock Images Grid
  2. User expands image preview of first already-preview-saved image
  3. User clicks View Preview Locate button in Media Gallery button
  4. Verify that preview image is displayed in the Media Gallery
@drpayyne
Copy link
Contributor

drpayyne commented Nov 5, 2019

@filmaj @sivaschenko, I understand the story is different, and functionality too. But I feel the test for this and #444 is the same. Both would be testing the Locate button. And this button is irrespective of whether an image is licensed or not. If there's a local copy of image (whether it's a preview or a fully sized licensed), Locate button appears and I feel the logic of the test is identical.

I've already created a PR for #444 at #639. Please refer the test and let me know.

Thanks.

@drpayyne
Copy link
Contributor

drpayyne commented Nov 5, 2019

With the generous help of @sivaschenko, I have come to this understanding of which button appears when and with what text in the image preview section. Also linked the MFTF test issues. So from the below understanding, I feel this is a duplicate of #444.

New image #440(in Media Gallery), #442(with label in Stock Grid)
Preview button text: Save Preview
License button text: License and Save

Already saved preview #440(in Media Gallery), #442(with label in Stock Grid)
Preview button text: Locate
License button text: License and Save

Already licensed on adobe stock (not saved locally) #443
No grey button
License button text: Save

Already saved preview and licensed in Adobe Stock (no licensed image locally) #443
Preview button text: Locate
License button text: Save

Licensed image locally #444
Preview button text: Locate
No red button

@filmaj
Copy link
Contributor Author

filmaj commented Nov 5, 2019

Hey @drpayyne, sorry, I'm a bit confused. Given your breakdown above, seems like there are several interactions at play and each changes the expected button text as well as which buttons are displayed. In that sense, I feel there is value in having separate tests for these various scenarios.

Or am I misunderstanding you?

@drpayyne
Copy link
Contributor

drpayyne commented Nov 5, 2019

@filmaj Yes, indeed. A separate test for each scenario would be better, in my opinion. At the moment, only #440 and #442 would need to have two tests each. Already developed two tests for #443 and created a PR.

But this issue is a duplicate of #444, don't you think? (test logic wise)

@sivaschenko
Copy link
Member

@drpayyne I don't think this is duplicate as the preconditions are different. It's just a very similar test in my opinion :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MFTF tests MFTF tests coverage
Projects
None yet
Development

No branches or pull requests

4 participants