Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No validation of streams #3

Open
blahah opened this issue May 16, 2017 · 0 comments
Open

No validation of streams #3

blahah opened this issue May 16, 2017 · 0 comments

Comments

@blahah
Copy link

blahah commented May 16, 2017

I recently hit a bug that was kinda hard to debug where I was accidentally passing a stream constructor rather than a stream to multi-read-stream. The error came from fairly deep inside pump.

Would you be open to a PR implementing simple validation of the input arguments using is-stream, and throwing a helpful error if any of the args isn't a stream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant