Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semi_join() erros #351

Closed
antonio-yu opened this issue Nov 3, 2021 · 4 comments
Closed

semi_join() erros #351

antonio-yu opened this issue Nov 3, 2021 · 4 comments

Comments

@antonio-yu
Copy link

from siuba import * 
from siuba.data import mtcars 

mtcars >> semi_join(_,mtcars)
 # Check for duplicates
KeyError: {'gear', 'carb', 'cyl', 'mpg', 'hp', 'qsec', 'wt', 'am', 'vs', 'disp', 'drat'}
@antonio-yu
Copy link
Author

@machow Hello, could you help seeing this issue?

@machow
Copy link
Owner

machow commented Nov 25, 2021

Hey--it looks like when no on columns are specified, semi_join tries to guess them. Unfortunately, it makes the guessed keys a set, which seems to not work in the merge.

Should be able to fix by specifying the columns to join on. I'm going to try and publish the stable branch as a release candidate today on pypi, and then can try a quick fix!

https://github.com/machow/siuba/blob/master/siuba/dply/verbs.py#L1093

@antonio-yu
Copy link
Author

@machow, this issue seems still exists in siuba '1.0.0a3'.

@machow machow moved this to In Progress in siuba Jan 13, 2022
@machow machow moved this from In Progress to Review in siuba Jan 13, 2022
@machow
Copy link
Owner

machow commented Jan 20, 2022

Ah, sorry--released 0.1.2 just now which should have the fix (note that I reverted the versioning back to 0.1.*, to make it easier for people to pip install by default, versus using alpha releases #353 )

@machow machow closed this as completed Jan 20, 2022
Repository owner moved this from Review to Done in siuba Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants