Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle data format version in loader and f/e #1612

Open
mwinokan opened this issue Dec 12, 2024 · 3 comments
Open

Handle data format version in loader and f/e #1612

mwinokan opened this issue Dec 12, 2024 · 3 comments

Comments

@mwinokan
Copy link
Collaborator

@tdudgeon please inform @kaliif where the data versioning will be in the XCA output for the loader to parse.

In the case where the major version differs between the new data and existing target then the upload should fail without trying

@mwinokan mwinokan added backend 2024-10-31 oscars WP1 OSCARS grant WP/task 1 labels Dec 12, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Fragalysis Dec 12, 2024
@mwinokan mwinokan moved this from Backlog to OSCARS in Fragalysis Dec 12, 2024
@phraenquex phraenquex moved this from OSCARS to In Progress (DEV) in Fragalysis Dec 12, 2024
@kaliif
Copy link
Collaborator

kaliif commented Dec 13, 2024

@mwinokan @tdudgeon something occurs to me only now - how do I know what the current version is? Is there maybe an online resource I can check?

@mwinokan
Copy link
Collaborator Author

mwinokan commented Dec 17, 2024

@tdudgeon says the data version of XCA is in the yaml output and this can be compared to the data version of previously uploaded targets.

@kaliif please bake in the supported data format major version in the loader code, i.e. currently it's version 2, and in future if there are breaking changes with XCA it will be version 3.

@boriskovar-m2ms points out that the f/e should show the data version in the target settings and flag targets with outdated data version as a toaster warning when opening the target.

@kaliif the above will require having the current version as part of the django context

@kaliif please also see about adding the current data format version to the version endpoint so that it can be shown in the hamburger menu

@mwinokan mwinokan changed the title Loader to parse data version from XCA output Handle data format version in loader and f/e Dec 17, 2024
@mwinokan
Copy link
Collaborator Author

mwinokan commented Jan 9, 2025

@kaliif will need incremental upload test data, and @mwinokan suggests taking the A71EV2A tarballs from the production stack.

@mwinokan mwinokan moved this from In Progress (DEV) to In staging - assess function vs spec in Fragalysis Jan 14, 2025
@mwinokan mwinokan moved this from In staging - assess function vs spec to Approved in staging - push to production in Fragalysis Jan 28, 2025
@mwinokan mwinokan moved this from Approved in staging - push to production to In production (Done) in Fragalysis Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In production (Done)
Development

No branches or pull requests

5 participants