Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit spec for LHS hit navigator search #1371

Open
5 tasks
phraenquex opened this issue Mar 5, 2024 · 2 comments
Open
5 tasks

Revisit spec for LHS hit navigator search #1371

phraenquex opened this issue Mar 5, 2024 · 2 comments
Assignees

Comments

@phraenquex
Copy link
Collaborator

phraenquex commented Mar 5, 2024

Use cases:

Spacer

(The original ticket entries don't match the ticket title: the thing below the line, and the two Mar 6/7 entries.)


This snapshot even recreates the search string (CX1134B) - but the LHS list doesn't shrink down to just that hit (the behaviour I expected/remembered).

https://fragalysis.xchem.diamond.ac.uk/viewer/react/projects/26/26

@boriskovar-m2ms
Copy link
Collaborator

This unfortunately works as designed. So many hits are visible in the hit navigator because they're visible in the NGL View. The rules for visibility and ordering of the LHS are so complicated that even I need to painstakingly debug the code to find out it's behaving in line with spec. For normal end user the behavior seems buggy or random at best. There is even a ticket somewhere, where the need to for some kind of simplification or maybe some feedback why hit is displayed to the user is described but I'm not able to find it.

@phraenquex phraenquex changed the title LHS hit navigator search doesn't work (maybe?) Revisit spec for LHS hit navigator search Mar 7, 2024
@phraenquex
Copy link
Collaborator Author

phraenquex commented Mar 7, 2024

First thing: give visibility to user to why something is on there. e.g. give a eye-type icon which will reveal that.

May well be superceded by #1322

@phraenquex phraenquex added 2023-11-02 yellow Too big for V2 and removed 2023-08-23 violet V2 full release labels Mar 7, 2024
@mwinokan mwinokan added 2024-03-15 indigo Data dissemination loose ends and removed 2023-11-02 yellow Too big for V2 labels Mar 13, 2024
@mwinokan mwinokan moved this to ASAP critical in Fragalysis May 29, 2024
@phraenquex phraenquex added 2024-06-14 mint Data dissemination 2 and removed 2024-03-15 indigo Data dissemination loose ends labels Jun 14, 2024
@mwinokan mwinokan assigned mwinokan and unassigned boriskovar-m2ms Jun 17, 2024
@phraenquex phraenquex added the 2024-09-17 olive data curation big items (too big for mint) label Sep 17, 2024
@mwinokan mwinokan removed the 2024-06-14 mint Data dissemination 2 label Nov 20, 2024
@mwinokan mwinokan moved this from olive to OSCARS in Fragalysis Nov 26, 2024
@mwinokan mwinokan added 2024-10-31 oscars WP1 OSCARS grant WP/task 1 and removed 2024-09-17 olive data curation big items (too big for mint) labels Nov 26, 2024
@mwinokan mwinokan moved this from OSCARS to olive in Fragalysis Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: olive
Development

No branches or pull requests

3 participants