Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: language dropdown styling #264

Merged
merged 2 commits into from
Nov 7, 2021
Merged

Conversation

ericswpark
Copy link
Contributor

@lxndrblz sorry about the multiple pull requests! Hopefully this is one of the last ones regarding the dropdown.

Before:
image
After:
image

Actually for the second commit is there a reason for the 5px padding on the left? Please let me know if I'm missing anything here and I'll drop the commit.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Owner

@lxndrblz lxndrblz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericswpark Commit looks good and works as expected.

@lxndrblz
Copy link
Owner

lxndrblz commented Nov 7, 2021

@ericswpark Regarding your question on the padding, I believe that it must have been some leftover from playing around. At least I could not see a reason for it to be there.

@lxndrblz lxndrblz merged commit e1817fe into lxndrblz:master Nov 7, 2021
@lxndrblz lxndrblz added the bug Something isn't working label Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants