Merge pull request #13 from oasis-engine/bug/fix-bounds-update

fix bounds update
luzhuang · Jan 28, 2021 · 4446f63 · 4446f63
2 parents 09893f3 + b925f92
commit 4446f63
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/packages/core/src/Renderer.ts b/packages/core/src/Renderer.ts
@@ -56,6 +56,9 @@ export abstract class Renderer extends Component {
   @ignoreClone
   private _normalMatrix: Matrix = new Matrix();
 
+  /**
+   * The bounding volume of the renderer.
+   */
   get bounds(): BoundingBox {
     const changeFlag = this._transformChangeFlag;
     if (changeFlag.flag) {

diff --git a/packages/core/src/geometry/GeometryRenderer.ts b/packages/core/src/geometry/GeometryRenderer.ts
@@ -67,9 +67,14 @@ export class GeometryRenderer extends Renderer {
    * @override
    */
   protected _updateBounds(worldBounds: BoundingBox): void {
-    const localBounds = this._geometry.bounds;
-    const worldMatrix = this._entity.transform.worldMatrix;
-
-    BoundingBox.transform(localBounds, worldMatrix, worldBounds);
+    const geometry = this._geometry;
+    if (geometry) {
+      const localBounds = geometry.bounds;
+      const worldMatrix = this._entity.transform.worldMatrix;
+      BoundingBox.transform(localBounds, worldMatrix, worldBounds);
+    } else {
+      worldBounds.min.setValue(0, 0, 0);
+      worldBounds.max.setValue(0, 0, 0);
+    }
   }
 }
diff --git a/packages/core/src/particle/index.ts b/packages/core/src/particle/index.ts
@@ -1 +1 @@
-export { ParticleRenderer } from "./particleRenderer";
+export { ParticleRenderer } from "./ParticleRenderer";
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		export { ParticleRenderer } from "./particleRenderer";
		export { ParticleRenderer } from "./ParticleRenderer";