Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Configuration class #45

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve Configuration class #45

wants to merge 3 commits into from

Conversation

lundybernard
Copy link
Owner

Fixes: #38

  • Add default config parameter values to the Configuration class.
  • The Configuration class now handles default values set in Config
    dataclasses. As a result, we no longer need the DataclassConfig source
    to lookup default values.
  • Improve Configuration repr for paths and child-configs
  • Remove DataclassConfig from example code and docs

@lundybernard
add path to Configuration class
2c7f5b8
@lundybernard
Add default parameters to Configuration class
f2fae64 
Fixes: #38

* The Configuration class now handles default values set in Config
dataclasses.  As a result, we no longer need the DataclassConfig source
to lookup default values.
* Improve Configuration repr for paths and child-configs
* Remove DataclassConfig from example code and docs
@lundybernard
Copy link
Owner Author

Additional change for consideration:
Change Configuration repr to display {self._path} <... instead of Root < by default.

@lundybernard lundybernard marked this pull request as ready for review August 24, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add path option to Configuration class
1 participant
@lundybernard