-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Japanese in sidebar menu #14
Comments
The sidebar shows the page title, or the url slug as a fallback. So you can have a Japanese title with english url and it will show the Japanese text in the menu. Note that for folders, this requires a index page to take the title from. You can create a index page by creating a
is equivalent to
And about the breadcrumb, I just checked it and yes, it's a bug in the Lume plugin. |
Appreciate it, that's an elegant solution to the problem. Thanks for the breadcrumb fix too! |
Just reopening to make a comment. So I got this up and running and see how having the index.md gives you the capability of setting the "folder" name. From a UX perspective, if you just want to use this feature for putting a Japanese name in place of an English URL, introducing the ability to click the menu title is perhaps confusing (if you have no intent to make index.md an actual index page, it just shows "page is empty"). If the user knows they just have to click the caret to get at the child pages, a consistent UX is better. Can there be a way to suppress link creation in the menu, for those index pages, if you don't need to show that empty page? Secondly regarding order, I added indexes just for two of four folders, because I don't need it for "M365" or "PROdb" which are just the way we write those in Japanese as well. I was able to control order by adding https://github.com/esolia/help.esolia.pro ![]() ![]() |
Not currently. And I'm not sure if it's easy to do that. Nav plugin is based on the URLs of the pages and the good practice of providing a page for every folder of a url. For example the url
As said, the plugin only use page urls to build the tree. The reason is: as you know, Lume allows to customize the url of a page, so a page stored in That being said, I know that this strictness doesn't fit well for all cases. I'll think of a elegant way to configure the order. |
well understood, thank you! |
hello - this a question/request and what appears to be a bug.
I know that I can get Japanese kanji names into the sidebar menu by setting the url param in each page, making the first part of the url kanji. For example:
url: /Bousai/esolia-bousai-links/
yields "Bousai" in the menu.url: /防災/esolia-bousai-links/
yields "防災" in the menu.In a Japanese context having 防災 makes more sense in the menu, but sometimes having kanji in an URL makes problems. The kanji get converted to entities sometimes, and this leads to too-long urls in some cases.
So my question is, is there a way to have
menu.js
pick up a kanji from somewhere to use in the sidebar display?Secondly, what I think is a bug. When I set the url to kanji, like
url: /防災/esolia-bousai-links/
, the breadcrumbs break. Please see the two screenshots showing where breadcrumbs are working, and not working when the url contains kanji.This has a "smell" of something needing to be sent to a filter to sanitize before doing the logic in
breadcrumbs.vto
.The text was updated successfully, but these errors were encountered: