Improve code_highlight configuration options type to be Partial #679
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make it so users of the Highlight Code Plugin don't have to pass all options to the configure wrapper for highlightjs.
The object is only merged with the
defaults
and then passed to PublicApi::configure which has a type signature itself of:configure: (options: Partial<HLJSOptions>) => void
https://github.com/highlightjs/highlight.js/blob/4e485f222e8c604b92937870414cf401e9dff31f/types/index.d.ts#L38
Related Issues
Example: I wanted to have the
pre code.mermaid-language
processed by another plugin so i wanted to add:Deno-ts then sais:
Check List
I assume it's not a big enough change to warrant tests or an entry in CHANGELOG.md.
CODE OF CONDUCT
CONTRIBUTING
send multiple pull request.
fmt
to fix the code format before commit.CHANGELOG.md
.