-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README on how to install with CocoaPods #329
Conversation
looks good to me. Thanks |
This should be merged, it's pretty useful |
Thanks @muhozi !
the above snippet was shared on #125 tested with versions:
|
e200d38
to
b49490a
Compare
b49490a
to
d6e413d
Compare
@alfonsodev Thanks for this, I've added that in the README. Thanks to @mikelovesrobots for the snippet I'm actually using this snippet for this package to work. I don't know how I forgot to add it in the README too 🙂. |
No worries! Cocoapods is awful. |
@alfonsodev I have the same setup as you, but I'm having a build error. you can help me?
|
@CesarDenis I haven't seen that error before, maybe you could create a separate issue with this error and all the data related to your Xcode version and react-native version and someone can help. |
Tks @alfonsodev, I opened a new issue #340 |
It's generally recommended that you do check your |
Add this script to scheme pre-actions:
Maybe someone knows a way to automatically put it into the scheme |
Why this isn't merged? Could've spared me hours of debugging |
* ruby scripts were refactored * environment values are now exposed to Info.plist via xcconfig file * environment values became available in Build Settings * cocoapods integration fixed - no need to add custom code to Podfile! (as suggested in this PR: lugg#329)
* ruby scripts were refactored * environment values are now exposed to Info.plist via xcconfig file * environment values became available in Build Settings * cocoapods integration fixed - no need to add custom code to Podfile! (as suggested in this PR: lugg#329)
* ruby scripts were refactored * environment values are now exposed to Info.plist via xcconfig file * environment values became available in Build Settings * cocoapods integration fixed - no need to add custom code to Podfile! (as suggested in this PR: lugg#329)
* ruby scripts were refactored * environment values are now exposed to Info.plist via xcconfig file * environment values became available in Build Settings * cocoapods integration fixed - no need to add custom code to Podfile! (as suggested in this PR: lugg#329)
Hi all, I changed the way this library integrates into ios project and now all issues with cocoapods should be fixed. PR is here: #349 please give it a try. |
|
||
**Cocoapods** | ||
|
||
If you are using **CocoaPods** in your project, set to `$(SRCROOT)/../node_modules/react-native-config/ios/ReactNativeConfig/GeneratedInfoPlistDotEnv.h` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this mean exactly? Where are you "setting" the .h file?
It works!!! even with the new React Native 0.60.0 |
Closing this. The issue was fixed in #349 |
* ruby scripts were refactored * environment values are now exposed to Info.plist via xcconfig file * environment values became available in Build Settings * cocoapods integration fixed - no need to add custom code to Podfile! (as suggested in this PR: lugg/react-native-config#329)
* ruby scripts were refactored * environment values are now exposed to Info.plist via xcconfig file * environment values became available in Build Settings * cocoapods integration fixed - no need to add custom code to Podfile! (as suggested in this PR: lugg/react-native-config#329)
After spending some time figuring out how this package can work in my project while using CocoaPods, I've found a working solution from the comment of the issue #125
This PR updates the guide on how to install this package if you are using CocoaPods(for iOS). This solves the issue faced by CocoaPods user when they try to run the app after installing this package, like issue #125.
Thanks to @clarsen for the comment on the issue.