use a pre-generated test vectors to test hkdfExpandLabel #3175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only reason we were using qtls.HkdfExpandLabel was to test our own implementation of HKDF-Expand-Label. By using a pre-generated test vector, we won't have to expose this function from qtls any more.
marten-seemann
force-pushed
the
dont-use-qtls-hkdf-expand-label
branch
from
807384c to
05af55b
Compare
Codecov Report
@@ Coverage Diff @@
## master #3175 +/- ##
==========================================
+ Coverage 85.35% 85.38% +0.03%
==========================================
Files 133 133
Lines 9824 9822 -2
==========================================
+ Hits 8385 8386 +1
+ Misses 1063 1060 -3
Partials 376 376
Continue to review full report at Codecov.
|
lucas-clemente
approved these changes
May 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only reason we were using qtls.HkdfExpandLabel was to test our own
implementation of HKDF-Expand-Label. By using a pre-generated test
vector, we won't have to expose this function from qtls any more.