make it possible to associate a ConnectionTracer with a Session #3146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
tracing-context
branch
from
e1e38d2 to
7844cfa
Compare
This context has the same value attached to it as the context returned by Session.Context(). In the case of a dialed connection, this context is derived from the context used for dialing.
marten-seemann
force-pushed
the
tracing-context
branch
from
7844cfa to
878e0b2
Compare
Codecov Report
@@ Coverage Diff @@
## master #3146 +/- ##
==========================================
+ Coverage 85.38% 85.41% +0.03%
==========================================
Files 131 131
Lines 9684 9698 +14
==========================================
+ Hits 8268 8283 +15
+ Misses 1046 1045 -1
Partials 370 370
Continue to review full report at Codecov.
|
|
SGTM. You could always refine this if users find it's not enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3145.
This PR implements a combination of the options discussed on the issue:
logging.Tracer.NewConnectionTracernow takes acontext.Context, which has values associated with it.Session.Contexthave a context with aSessionTracingKeyvalue (which is a uint64).NewConnectionTraceris derived from the context passed toDial. This allows us (for example) to associate the peer ID we were dialing even if the handshake fails (and noSessionis returned).@mvdan, how does this look to you?