fix race condition when receiving 0-RTT packets #3074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
fix-0rtt-queue-race
branch
2 times, most recently
from
2cf5294 to
496b0e4
Compare
Codecov Report
@@ Coverage Diff @@
## master #3074 +/- ##
==========================================
- Coverage 85.84% 85.71% -0.12%
==========================================
Files 132 131 -1
Lines 9519 9520 +1
==========================================
- Hits 8171 8160 -11
- Misses 983 991 +8
- Partials 365 369 +4
Continue to review full report at Codecov.
|
marten-seemann
force-pushed
the
fix-0rtt-queue-race
branch
2 times, most recently
from
6a02c4d to
acf6db7
Compare
lucas-clemente
approved these changes
Mar 9, 2021
marten-seemann
force-pushed
the
fix-0rtt-queue-race
branch
from
acf6db7 to
227f720
Compare
marten-seemann
force-pushed
the
fix-0rtt-queue-race
branch
from
227f720 to
e51e0c4
Compare
This prevents a race condition between receiving of 0-RTT packets and the creation of new session.
marten-seemann
force-pushed
the
fix-0rtt-queue-race
branch
from
e51e0c4 to
2bd316b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2629. Depends #3066.
By moving the logic for queueing 0-RTT packets into the packet handler map, we can avoid the race condition between receiving 0-RTT packets and the creation of new sessions.