Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reenable key updates for HTTP/3 #3017

Merged
merged 1 commit into from
Jan 23, 2021
Merged

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Jan 20, 2021

Fixes #2926.

Chrome was recently updated to v88, which is able to handle key updates correctly.

Chrome was recently updated to v88, which is able to handle key updates
correctly.
@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #3017 (e4dab7f) into master (53b1cbb) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3017      +/-   ##
==========================================
- Coverage   86.13%   86.13%   -0.00%     
==========================================
  Files         135      135              
  Lines        9455     9454       -1     
==========================================
- Hits         8144     8143       -1     
  Misses        952      952              
  Partials      359      359              
Impacted Files Coverage Δ
http3/server.go 69.06% <ø> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53b1cbb...e4dab7f. Read the comment docs.

@marten-seemann marten-seemann merged commit a1fb80d into master Jan 23, 2021
@marten-seemann marten-seemann deleted the h3-reenable-key-updates branch January 25, 2021 07:22
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reenable key updates in HTTP/3 once Chrome 87 is not used any more
2 participants