Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log all reasons why a connection is closed #2669

Merged
merged 2 commits into from
Jul 10, 2020
Merged

Conversation

marten-seemann
Copy link
Member

Fixes #2647.

@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #2669 into master will increase coverage by 0.03%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2669      +/-   ##
==========================================
+ Coverage   86.62%   86.65%   +0.03%     
==========================================
  Files         122      123       +1     
  Lines        9749     9778      +29     
==========================================
+ Hits         8445     8473      +28     
  Misses        971      971              
- Partials      333      334       +1     
Impacted Files Coverage Δ
qlog/event.go 95.98% <ø> (ø)
session.go 77.11% <70.00%> (+0.04%) ⬆️
logging/close_reason.go 100.00% <100.00%> (ø)
qlog/qlog.go 95.35% <100.00%> (-0.02%) ⬇️
qlog/types.go 84.92% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53856bd...f93708a. Read the comment docs.

@marten-seemann marten-seemann merged commit e7fa420 into master Jul 10, 2020
@marten-seemann marten-seemann deleted the better-close-reason branch July 10, 2020 12:37
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConnectionTracer.ClosedConnection() only called on connection timeouts
2 participants