fix flaky cancelation integration test #2649
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a send stream is canceled (either by the user calling
CancelWrite()
, or by receiving a STOP_SENDING frame), theClose()
method will return an error. This happened occasionally in the cancellation integration test.On a more general note, I'm not sure if this API makes sense. OTOH, this is the only way for the user to learn that a stream has been canceled if the STOP_SENDING frame is received after the
Write()
call returned. We should probably include the error code in the error message then. @lucas-clemente, wdyt?