authenticate connection IDs #2567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2567 +/- ##
==========================================
- Coverage 86.25% 86.25% -0.00%
==========================================
Files 122 122
Lines 9645 9717 +72
==========================================
+ Hits 8319 8381 +62
- Misses 988 997 +9
- Partials 338 339 +1
Continue to review full report at Codecov.
|
marten-seemann
force-pushed
the
authenticate-connection-ids
branch
4 times, most recently
from
3af5f01 to
bfab263
Compare
Closed
marten-seemann
force-pushed
the
authenticate-connection-ids
branch
from
bfab263 to
4f19b15
Compare
lucas-clemente
approved these changes
May 31, 2020
| return | ||
| // check the initial_source_connection_id | ||
| if !params.InitialSourceConnectionID.Equal(s.handshakeDestConnID) { | ||
| return qerr.NewError(qerr.TransportParameterError, fmt.Sprintf("expected initial_source_connection_id to equal %s, is %s", s.handshakeDestConnID, params.InitialSourceConnectionID)) |
There was a problem hiding this comment.
Could exposing the expected id leak info to an attacker?
There was a problem hiding this comment.
Not really. The connection ID has already been used on the Initial packet, so it's known to a MITM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2529.