rewrite the frame sorter #2561
Merged
rewrite the frame sorter #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
rewrite-frame-sorter
branch
2 times, most recently
from
0346e79 to
3a08979
Compare
Codecov Report
@@ Coverage Diff @@
## master #2561 +/- ##
==========================================
+ Coverage 86.17% 86.22% +0.05%
==========================================
Files 122 122
Lines 9550 9584 +34
==========================================
+ Hits 8229 8263 +34
- Misses 983 984 +1
+ Partials 338 337 -1
Continue to review full report at Codecov.
|
marten-seemann
force-pushed
the
rewrite-frame-sorter
branch
from
3a08979 to
39fe927
Compare
lucas-clemente
approved these changes
May 25, 2020
| return gap.Prev(), false | ||
| } | ||
| } | ||
| panic("no gap found") |
There was a problem hiding this comment.
Could an attacker trigger this panic by sending us a frame with offset = MaxByteCount?
There was a problem hiding this comment.
We'd only read that frame if we read everything before MaxByteCount. Also, we'd trigger a flow control error before even enqueuing such a frame.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2533, fixes #2544, fixes #2545. Fixes #2521, assuming that this error was a result of the race condition.
Adds a bunch of new test cases, including a randomized test, which would have caught the bugs.