Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calculate version negotiation packet size to avoid bytes.Buffer growi… #2542

Merged
merged 1 commit into from
May 13, 2020

Conversation

mw-jn
Copy link
Contributor

@mw-jn mw-jn commented May 13, 2020

Fixes #2541.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@marten-seemann marten-seemann self-requested a review May 13, 2020 04:48
@codecov-io
Copy link

codecov-io commented May 13, 2020

Codecov Report

Merging #2542 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2542   +/-   ##
=======================================
  Coverage   86.15%   86.15%           
=======================================
  Files         122      122           
  Lines        9542     9542           
=======================================
  Hits         8220     8220           
  Misses        984      984           
  Partials      338      338           
Impacted Files Coverage Δ
internal/wire/version_negotiation.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bcb4e6...38691a1. Read the comment docs.

@mw-jn
Copy link
Contributor Author

mw-jn commented May 13, 2020

@googlebot I signed it!

@googlebot
Copy link
Collaborator

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@mw-jn
Copy link
Contributor Author

mw-jn commented May 13, 2020

@googlebot I fixed it.

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@marten-seemann
Copy link
Member

Thank you!

@marten-seemann marten-seemann merged commit bb6fdf2 into quic-go:master May 13, 2020
@Stebalien Stebalien mentioned this pull request May 26, 2020
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

calculate version negotiation packet size
4 participants