make it more likely that a STREAM frame is bundled with the FIN #2504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2435.
Currently, on
Stream.Write()
, we save the slice indataForWriting
, and pop STREAM frames from that slice.Write
only returns after all the data has been popped in STREAM frames.This PR changes this logic: As soon as
dataForWriting
becomes smaller than a certain sizex
, it's copied to a STREAM frame, which can the be popped the next time we assemble a packet. This allows us to returnWrite()
when all data butx
bytes have been sent out. When the user now callsClose()
, this is much more likely to happen before we popped that last STREAM frame, allowing us to set the FIN bit on that frame (and avoiding sending out an empty STREAM frame with FIN set in a separate packet).