Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run the internal and http3 tests with race detector on Travis #2385

Merged
merged 4 commits into from
May 5, 2020

Conversation

marten-seemann
Copy link
Member

Depends on #2380.

@codecov-io
Copy link

codecov-io commented Feb 25, 2020

Codecov Report

Merging #2385 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2385      +/-   ##
==========================================
- Coverage   86.15%   86.13%   -0.02%     
==========================================
  Files         122      122              
  Lines        9542     9681     +139     
==========================================
+ Hits         8220     8338     +118     
- Misses        984      995      +11     
- Partials      338      348      +10     
Impacted Files Coverage Δ
internal/ackhandler/sent_packet_handler.go 74.33% <0.00%> (+3.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d83009...b128ad5. Read the comment docs.

@marten-seemann marten-seemann force-pushed the race-detector branch 2 times, most recently from e1322a8 to 5a82ffb Compare February 25, 2020 13:18
@marten-seemann
Copy link
Member Author

@lucas-clemente Please have another look. I had to make a lot of changes to this PR.
Note the trick using go:linkname in the handshake tests to access unexported functions in the qtls package without any external dependencies.

@marten-seemann marten-seemann merged commit ff68196 into master May 5, 2020
@marten-seemann marten-seemann deleted the race-detector branch May 5, 2020 12:13
@Stebalien Stebalien mentioned this pull request May 26, 2020
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants