fix(Effects): Reverting fix final opacity value on fade method

lucaperret · Aug 10, 2017 · a457b58 · a457b58
1 parent 8e76bdb
commit a457b58
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/src/effects.js b/src/effects.js
@@ -12,8 +12,7 @@
  * @param {boolean} isFadeIn Determine fadeIn or fadeOut
  */
 function fade (element, duration = 400, isFadeIn) {
-  const opacity = isFadeIn ? 0 : 1
-  element.style.opacity = opacity
+  element.style.opacity = isFadeIn ? 0 : 1
 
   let last = +new Date()
   function tick () {
@@ -24,8 +23,6 @@ function fade (element, duration = 400, isFadeIn) {
     const targetOpacity = isFadeIn ? +element.style.opacity < 1 : +element.style.opacity > 0
     if (targetOpacity) {
       (window.requestAnimationFrame && requestAnimationFrame(tick)) || setTimeout(tick, 16)
-    } else {
-      element.style.opacity = isFadeIn ? 1 : 0
     }
   }