Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylesheet should allow for better layout #9

Closed
louismerlin opened this issue Feb 11, 2024 · 4 comments
Closed

Stylesheet should allow for better layout #9

louismerlin opened this issue Feb 11, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@louismerlin
Copy link
Owner

Right now concrete.css does not render well when using the following HTML layout:

<header>
</header>
<main>
</main>
<footer>
</footer>

This layout should be supported, and even potentially used by https://concrete.style/.

@louismerlin louismerlin added the bug Something isn't working label Feb 11, 2024
@hollisticated-horse
Copy link

hollisticated-horse commented Mar 8, 2024

whats the benefit of this layout over the other layout ? less nesting ?

@louismerlin
Copy link
Owner Author

The inherent problem of the current layout is not nesting, it is that it is not the typical way the header, main and footer elements are arranged in a simple HTML document.

Adding support for this simpler layout will make concrete compatible by default with more pages without the need for any modification of the HTML document.

@louismerlin
Copy link
Owner Author

I've worked on this in the no-resizing branch. The code is also available in v3.0.0-next.0.

@louismerlin
Copy link
Owner Author

Closed by #13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants