Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate when stdin is closed with --inline-info #273

Closed
Korkman opened this issue Feb 25, 2020 · 3 comments
Closed

Indicate when stdin is closed with --inline-info #273

Korkman opened this issue Feb 25, 2020 · 3 comments

Comments

@Korkman
Copy link

Korkman commented Feb 25, 2020

When piping to skim, the tiny dot indicator in the lower right corner only flashes when lines are received. How to know when a slow search is complete? There should be an indicator for closed stdin.

@lotabout
Copy link
Collaborator

image

@Korkman

  1. When there are still input from either stdin or command output, the spinner would show(50ms after first read)
  2. The dot in the lower right actually indicates the matcher is working or not.

The spinner is designed for human, the dot is designed for CI. Or please explain your use case if it doesn't meet your need. Thanks!

@Korkman Korkman changed the title Indicate when stdin is closed Indicate when stdin is closed with --inline-info Feb 26, 2020
@Korkman
Copy link
Author

Korkman commented Feb 26, 2020

The spinner seems to be missing with --inline-info. Thanks for your swift response!

@lotabout
Copy link
Collaborator

Trying to add a spinner for inline-mode, just like the following:

>  < 5/10
>  - 5/10
>  < 5/11
>  - 5/12
   `--- spinner

lotabout added a commit that referenced this issue Feb 28, 2020
Fix #273: add spinner for inline-info mode
makovich pushed a commit to makovich/skim that referenced this issue May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants