Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BTree comparisons (subset/superset) may assert on certain shared subtrees #21

Closed
lorentey opened this issue Nov 7, 2016 · 1 comment
Closed

BTree comparisons (subset/superset) may assert on certain shared subtrees #21

lorentey opened this issue Nov 7, 2016 · 1 comment
Labels
bug

Comments

@lorentey
Copy link
Collaborator

lorentey commented Nov 7, 2016

The following functions sometimes crash with assertion failures when the rightmost leaf node of other is also found in self:

BTree.isSubset(of:)
BTree.isStrictSubset(of:)
BTree.isSuperset(of:)
BTree.isStrictSuperset(of:)
@lorentey lorentey added the bug label Nov 7, 2016
lorentey added a commit that referenced this issue Nov 7, 2016
@lorentey
Add more tests comparing trees with shared subtrees
d1f68f5 
The new tests detect an assert in subset comparisons. (issue #21)
@lorentey
Copy link
Collaborator Author

lorentey commented Nov 7, 2016

Unit tests for this were added in d1f68f5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lorentey