Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENBSeries incompatible to NVTF and NVHR #352

Closed
pStyl3 opened this issue Oct 1, 2023 · 5 comments
Closed

ENBSeries incompatible to NVTF and NVHR #352

pStyl3 opened this issue Oct 1, 2023 · 5 comments

Comments

@pStyl3
Copy link
Member

pStyl3 commented Oct 1, 2023

Reference: #349

ENBSeries
New Vegas Tick Fix (NVTF)
New Vegas Heap Replacer (NVHR)

ENBSeries seems to be incompatible with NVTF and NVHR.
Consider adding a message in LOOT that informs the user of them being incompatible.

@MacSplody
Copy link
Member

We'll need a new message in prelude for incompatible, to use in globals.
Is it possible to use existing localisation used for inc:?

@pStyl3
Copy link
Member Author

pStyl3 commented Apr 14, 2024

The inc message is defined in game.cpp here and it reads:

This plugin is incompatible with \"{0}\", but both are present.

As such, the masterlist entry

  - name: 'WMIMNV.esp'
    inc:
      - 'EVE FNV - ALL DLC.esp'

will result in the following, if both plugins are present:

grafik

If we wanted to warn about an incompatibility between WMIMNV.esp and ENBSeries, we could expand the inc list of WMIMNV.esp like so:

  - name: 'WMIMNV.esp'
    inc:
      - name: '../ENBInjector.exe'
        display: 'ENBSeries (InjectorVersion)'
      - name: '../enbhost.exe'
        display: 'ENBSeries (WrapperVersion)'

It would result in:

grafik


This issue however is about warning about an incompatibility between

  • ENBSeries and New Vegas Tick Fix (NVSE/Plugins/NVTF.dll)
  • ENBSeries and New Vegas Heap Replacer (NVHR/nvhr_avx.dll)

where no plugins are involved, so the inc message doesn't seem appropriate.

The best course is likely indeed to create a new message in the prelude and utilise it in the masterlist's global node.

@pStyl3
Copy link
Member Author

pStyl3 commented Apr 14, 2024

I would suggest the following:

prelude.yaml

  - &incompatible
    type: error
    content:
      - lang: en
        text: '{0} is incompatible with {1}, but both are present.'
    subs:
      - 'non-plugin mod 0'
      - 'non-plugin mod 1'
    condition: 'file("NVSE/Plugins/0.dll") and file("NVSE/Plugins/1.dll")'

masterlist.yaml

prelude:
  common:
  # Global Anchors

    - &incompatible
      type: error
      content: '{0} is incompatible with {1}, but both are present.'


globals:
# ENBSeries - NVHR
  - <<: *incompatible
    subs:
      - '[ENBSeries](http://enbdev.com/mod_falloutnv_v0451.htm)'
      - '[NVHR - New Vegas Heap Replacer](https://www.nexusmods.com/newvegas/mods/69779/)'
    condition: 'file("NVHR/nvhr_avx.dll") and (file("../ENBInjector.exe") or file("../enbhost.exe"))'


# ENBSeries - NVTF
  - <<: *incompatible
    subs:
      - '[ENBSeries](http://enbdev.com/mod_falloutnv_v0451.htm)'
      - '[NVTF - New Vegas Tick Fix](https://www.nexusmods.com/newvegas/mods/66537/)'
    condition: 'file("NVSE/Plugins/NVTF.dll") and (file("../ENBInjector.exe") or file("../enbhost.exe"))'

Result:
grafik

@MacSplody
Copy link
Member

MacSplody commented Apr 14, 2024

Yeah that looks good, thanks.

@pStyl3
Copy link
Member Author

pStyl3 commented Apr 14, 2024

Closing the issue as completed, as the message has been added.

@pStyl3 pStyl3 closed this as completed Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants