Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react): auto handle callback #92

Merged
merged 2 commits into from
Nov 11, 2021
Merged

feat(react): auto handle callback #92

merged 2 commits into from
Nov 11, 2021

Conversation

wangsijie
Copy link
Contributor

Summary

use logtoClient.isLoginCallback to auto detect if need to handle callback

Linear Issue Reference

LOG-232

Testing

use-logto.spec.tsx

simeng-li
simeng-li reviewed Nov 10, 2021
View reviewed changes
@wangsijie wangsijie requested a review from simeng-li November 10, 2021 03:17
simeng-li
simeng-li approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@simeng-li simeng-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangsijie wangsijie merged commit 58ee454 into master Nov 11, 2021
@wangsijie wangsijie deleted the wangsijie--handle-callback branch November 11, 2021 02:43
@wangsijie wangsijie mentioned this pull request Nov 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeng-li simeng-li simeng-li approved these changes

@gao-sun gao-sun Awaiting requested review from gao-sun

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangsijie @simeng-li