Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: transaction manager #51

Merged
merged 7 commits into from
Oct 27, 2021
Merged

feat: transaction manager #51

merged 7 commits into from
Oct 27, 2021

Conversation

wangsijie
Copy link
Contributor

Summary

Sign in process is a transaction: generate random stuff, go to logto website, then redirect back to user's site and verify the stuff created.

Those random stuff is per-transaction, can not be reused, so need a manager to save transaction data.

Linear Issue Reference

Testing

UT

Copy link
Member

@gao-sun gao-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to use session for naming consistency instead of transaction.

@wangsijie
Copy link
Contributor Author

I would prefer to use session for naming consistency instead of transaction.

agree, session would be more familiar in auth

@wangsijie wangsijie requested a review from gao-sun October 26, 2021 03:14
@wangsijie wangsijie requested a review from gao-sun October 26, 2021 10:16
Copy link
Contributor

@simeng-li simeng-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments addressed

@wangsijie wangsijie merged commit 9aadf06 into master Oct 27, 2021
@wangsijie wangsijie deleted the feat/transaction-manager branch October 27, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants