Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(next): grant access token and check expiration #361

Merged
merged 1 commit into from
Jul 21, 2022
Merged

feat(next): grant access token and check expiration #361

merged 1 commit into from
Jul 21, 2022

Conversation

wangsijie
Copy link
Contributor

Summary

Implement expiration policy:

  1. set cookie's max-age to the same as refresh token
  2. if the access token is valid, the session is authenticated
  3. if the access token is expired, try to grant new with refresh token

Testing

Local tested with sample code.

@linear
Copy link

linear bot commented Jul 20, 2022

LOG-3745 Expiration check

@wangsijie wangsijie force-pushed the sijie-log-3581-sign-out branch from e76a869 to a8a7f71 Compare July 20, 2022 03:14
Base automatically changed from sijie-log-3581-sign-out to master July 20, 2022 04:02
@wangsijie wangsijie force-pushed the sijie-log-3745-expiration branch 4 times, most recently from a95bc99 to ed7312a Compare July 20, 2022 04:58
@wangsijie wangsijie force-pushed the sijie-log-3745-expiration branch from ed7312a to d192f64 Compare July 20, 2022 10:01
gao-sun
gao-sun reviewed Jul 21, 2022
View reviewed changes
@wangsijie wangsijie merged commit 3171b58 into master Jul 21, 2022
@wangsijie wangsijie deleted the sijie-log-3745-expiration branch July 21, 2022 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gao-sun gao-sun gao-sun left review comments

@charIeszhao charIeszhao charIeszhao approved these changes

@IceHe IceHe Awaiting requested review from IceHe

@xiaoyijun xiaoyijun Awaiting requested review from xiaoyijun

@darcyYe darcyYe Awaiting requested review from darcyYe

@simeng-li simeng-li Awaiting requested review from simeng-li

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wangsijie @charIeszhao @gao-sun