Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: codeVerifier and codeChallenge #35

Merged
merged 3 commits into from
Oct 15, 2021
Merged

Conversation

wangsijie
Copy link
Contributor

No description provided.

@wangsijie wangsijie force-pushed the wangsijie--generators branch from e3d3b41 to 0df781a Compare October 14, 2021 02:33
Copy link
Contributor

@simeng-li simeng-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM. let's discuss offline on this and refactor later if needed.

@wangsijie wangsijie requested a review from gao-sun October 14, 2021 06:34
@wangsijie wangsijie merged commit 7efe0eb into master Oct 15, 2021
@wangsijie wangsijie deleted the wangsijie--generators branch October 15, 2021 02:33
wangsijie added a commit that referenced this pull request Oct 15, 2021
* feat: codeVerifier and codeChallenge

* refactor: use crypto directly
wangsijie added a commit that referenced this pull request Oct 15, 2021
* feat: verifyIdToken

* fix: return JWTVerifyResult

* feat: codeVerifier and codeChallenge (#35)

* feat: codeVerifier and codeChallenge

* refactor: use crypto directly

* test: jsdom axios config

* chore: generateKeyPair type check on jest

* chore: comments on jest.setup.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants