Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(browser): should use prompt param on sign-in #319

Merged
merged 1 commit into from
Jun 30, 2022
Merged

fix(browser): should use prompt param on sign-in #319

merged 1 commit into from
Jun 30, 2022

Conversation

charIeszhao
Copy link
Member

Summary

Should use user specified prompt type in logtoClient when calling .signIn() method

Testing

  • Unit test case added, all passed
  • Tested locally with React sample. Login was successful, and there was no refreshToken in localStorage

@charIeszhao charIeszhao requested review from IceHe and gao-sun June 30, 2022 04:13
@charIeszhao charIeszhao self-assigned this Jun 30, 2022
@linear
Copy link

linear bot commented Jun 30, 2022 •
edited by charIeszhao
Loading

LOG-3268 (JS browser SDK) Use prompt param on calling sign in

gfm warning, note

images

@gao-sun gao-sun enabled auto-merge (squash) June 30, 2022 04:14
IceHe
IceHe approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@IceHe IceHe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gao-sun gao-sun merged commit 08ceb64 into master Jun 30, 2022
@gao-sun gao-sun deleted the charles-log-3268-use-custom-prompt-on-sign-in branch June 30, 2022 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceHe IceHe IceHe approved these changes

@gao-sun gao-sun gao-sun approved these changes

Assignees

@charIeszhao charIeszhao

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charIeszhao @IceHe @gao-sun