feat(browser): sign-in session storage #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceHe
force-pushed
the
icehe-log-1544-sign-in-session-storage
branch
from
b29684b to
5e2856f
Compare
IceHe
force-pushed
the
icehe-log-1544-sign-in-session-storage
branch
from
5e2856f to
3778d39
Compare
simeng-li
reviewed
Feb 14, 2022
There was a problem hiding this comment.
nit: wondering whether the signInSession is the only session storage we gonna have.
Just personal preference, instead of defining a signInSession instance within the logtoClient. We could just have to simple sessions util methods sth like
getSessionStorage<T>(key: string, guard?: SuperstructSchema): T
setSessionStorage(key:string, data: any);All we need to call getSessionStorage and setSessionStorage wherever it is needed. And util methods can be tested individually.
gao-sun
reviewed
Feb 14, 2022
IceHe
force-pushed
the
icehe-log-1544-sign-in-session-storage
branch
4 times, most recently
from
4a3a5fa to
32fa755
Compare
IceHe
force-pushed
the
icehe-log-1544-sign-in-session-storage
branch
3 times, most recently
from
9e19dbf to
8138cfd
Compare
wangsijie
reviewed
Feb 15, 2022
wangsijie
reviewed
Feb 15, 2022
IceHe
force-pushed
the
icehe-log-1544-sign-in-session-storage
branch
4 times, most recently
from
05b08b5 to
de95f51
Compare
IceHe
force-pushed
the
icehe-log-1544-sign-in-session-storage
branch
2 times, most recently
from
ea0a03e to
13761b8
Compare
Merged
IceHe
force-pushed
the
icehe-log-1544-sign-in-session-storage
branch
from
13761b8 to
029c8c4
Compare
gao-sun
reviewed
Feb 15, 2022
IceHe
force-pushed
the
icehe-log-1544-sign-in-session-storage
branch
from
029c8c4 to
d79bfb0
Compare
gao-sun
approved these changes
Feb 15, 2022
IceHe
force-pushed
the
icehe-log-1544-sign-in-session-storage
branch
from
d79bfb0 to
25bd83d
Compare
gao-sun
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
feat(browser): sign-in session storage
Related #170
Linear Issue Reference
LOG-1544
LOG-790
LOG-882
Testing
@logto-io/eng