Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(js): export in index.ts #159

Merged
merged 1 commit into from
Feb 7, 2022
Merged

chore(js): export in index.ts #159

merged 1 commit into from
Feb 7, 2022

Conversation

IceHe
Copy link
Contributor

@IceHe IceHe commented Feb 7, 2022 •
edited
Loading

Summary

chore(js): export in index.ts

Linear Issue Reference

None

Testing

Pass all existing tests.

@logto-io/eng

@IceHe IceHe changed the title feat(browser): export in index.ts chore(js): export in index.ts Feb 7, 2022
@IceHe IceHe marked this pull request as draft February 7, 2022 08:14
@gao-sun
Copy link
Member

gao-sun commented Feb 7, 2022

will it be better to create index.ts in utils and core separately?

@IceHe IceHe marked this pull request as ready for review February 7, 2022 08:23
@IceHe IceHe force-pushed the icehe-chore-export-in-index-ts branch from 0c484be to c7aaca4 Compare February 7, 2022 08:32
@IceHe
Copy link
Contributor Author

IceHe commented Feb 7, 2022

will it be better to create index.ts in utils and core separately?

Improved, PTAL @gao-sun

@IceHe IceHe merged commit 423c185 into master Feb 7, 2022
@IceHe IceHe deleted the icehe-chore-export-in-index-ts branch February 7, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeng-li simeng-li simeng-li approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IceHe @gao-sun @simeng-li