Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(js): verifyIdToken #127

Merged
merged 1 commit into from
Jan 21, 2022
Merged

feat(js): verifyIdToken #127

merged 1 commit into from
Jan 21, 2022

Conversation

IceHe
Copy link
Contributor

@IceHe IceHe commented Jan 18, 2022 •
edited
Loading

Summary

  • Add verifyIdToken
    • Custom Error LogtoError

Linear Issue Reference

LOG-1356

Testing

  • valid ID Token should not throw
  • mismatched signature should throw
  • mismatched issuer should throw
  • mismatched audience should throw
  • expired ID Token should throw
  • issued at time, too far away from current time, should throw

@logto-io/eng

@IceHe IceHe changed the title feat(js): decodeIdToken feat(js): verifyIdToken Jan 18, 2022
@IceHe IceHe force-pushed the icehe-log-1356 branch 6 times, most recently from a624f2b to edda16f Compare January 20, 2022 07:10
@IceHe IceHe marked this pull request as ready for review January 20, 2022 07:11
gao-sun
gao-sun reviewed Jan 20, 2022
View reviewed changes
@IceHe IceHe added the feature Cool stuff label Jan 20, 2022
@IceHe IceHe requested review from wangsijie and gao-sun January 20, 2022 10:17
@IceHe IceHe force-pushed the icehe-log-1356 branch 2 times, most recently from 36f6f91 to 39d0c8d Compare January 21, 2022 03:29
@IceHe IceHe requested a review from gao-sun January 21, 2022 06:21
@IceHe IceHe force-pushed the icehe-log-1356 branch 2 times, most recently from 70e0f49 to e80f762 Compare January 21, 2022 07:15
gao-sun
gao-sun approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@gao-sun gao-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@IceHe IceHe merged commit 954dc6d into master Jan 21, 2022
@IceHe IceHe deleted the icehe-log-1356 branch January 21, 2022 07:35
@IceHe IceHe mentioned this pull request Jan 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gao-sun gao-sun gao-sun approved these changes

@wangsijie wangsijie Awaiting requested review from wangsijie wangsijie is a code owner

Assignees
No one assigned
Labels
feature Cool stuff
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IceHe @wangsijie @gao-sun