You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It looks like format_body is not calling close on the response body after iterating over it. I found this when trying to use Rack::CommonLogger with my app and not seeing the expected log entries show up in my CloudWatch logs. It turns out this middleware relies on body.close to be called to emit a log message.
Since this is part of the Rack spec to call close if the body responds to it, can format_body be updated to do this? I was able to get this middleware working after patching locally, so I can submit a PR with a fix if you'd like.
The text was updated successfully, but these errors were encountered:
It looks like
format_body
is not callingclose
on the response body after iterating over it. I found this when trying to useRack::CommonLogger
with my app and not seeing the expected log entries show up in my CloudWatch logs. It turns out this middleware relies onbody.close
to be called to emit a log message.Since this is part of the Rack spec to call
close
if the body responds to it, canformat_body
be updated to do this? I was able to get this middleware working after patching locally, so I can submit a PR with a fix if you'd like.The text was updated successfully, but these errors were encountered: