Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to disable SSL certificate verify #619

Closed
radiantone opened this issue Jul 8, 2017 · 3 comments
Closed

Ability to disable SSL certificate verify #619

radiantone opened this issue Jul 8, 2017 · 3 comments

Comments

@radiantone
Copy link

Please allow a flag such as --disable-ssl-verify that will ignore certificate verify errors when testing a website.

@cgoldberg
Copy link
Member

I don't think it makes sense to add this as a command line option. It won't be applicable in many cases, like when writing a locustfile with a custom client.

I think this is best handled in code when writing your locustfile. You can disable cert verification by passing verify=False when making HTTP requests from client.

For examples, see #300

@radiantone
Copy link
Author

radiantone commented Jul 13, 2017

Here is the rationale. Yes, you can put in your tests whether to verify or not. But in reality, we want to test load on our systems not whether SSL is good or not. There are different systems in the chain before production. Not all of them have valid certificates, nor need to. I don't want to write and maintain separate yet identical functional tests simply to turn SSL verify on or off. I would rather use the same suite of tests and override the HTTP setting from command line to disable it. In other less frequent situations you just encounter a bad certificate in a system you are testing (maybe it expired). You don't want to A) Hang up your testing because of this bad cert or B) Edit your tests (what if there are 1000's?) to reflect this temporary situation.

@cgoldberg
Copy link
Member

I would rather use the same suite of tests and override
the HTTP setting from command line to disable it

or you could use environment variables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants