Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ refactor: refactor Minimax with LobeOpenAICompatibleFactory #5325

Merged
merged 8 commits into from
Jan 15, 2025
Merged

♻️ refactor: refactor Minimax with LobeOpenAICompatibleFactory #5325

merged 8 commits into from
Jan 15, 2025

Conversation

hezhijie0327
Copy link
Contributor

@hezhijie0327 hezhijie0327 commented Jan 7, 2025 •
edited
Loading

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

  1. Minimax 切回 LobeOpenAICompatibleFactory
  2. 保留原有参数限制
  3. 更新价格及 abab7-chat-preview 模型
  4. 为 abab6.5s abab7-chat-preview 添加 vision 标签
  5. 添加 maxOutput 参数，引入 getMinimaxMaxOutputs 函数控制 max_tokens
  6. 更新 aiModels
功能 截图
对话 image
工具调用 image
多模态 image
长文本 image

📝 补充信息 | Additional Information

参数 引用
OpenAI SDK image
多模态参数 image
max_tokens 参数 image

@vercel Vercel
Copy link

vercel bot commented Jan 7, 2025

@hezhijie0327 is attempting to deploy a commit to the LobeHub Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @hezhijie0327

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献，请确保您已经遵循了我们的贡献指南，我们会尽快审查它。
如果您遇到任何问题，请随时与我们联系。

@codecov Codecov
Copy link

codecov bot commented Jan 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.28090% with 22 lines in your changes missing coverage. Please review.

Project coverage is 93.06%. Comparing base (32013b4) to head (c924858).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/libs/agent-runtime/minimax/index.ts 43.58% 22 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5325      +/-   ##
==========================================
- Coverage   93.07%   93.06%   -0.02%     
==========================================
  Files         631      629       -2     
  Lines       55367    55209     -158     
  Branches     2895     4006    +1111     
==========================================
- Hits        51534    51378     -156     
+ Misses       3833     3831       -2
Flag Coverage Δ
app 93.06% <75.28%> (-0.02%) ⬇️
server 97.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hezhijie0327 hezhijie0327 marked this pull request as ready for review January 7, 2025 17:13
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jan 7, 2025
arvinxx
arvinxx reviewed Jan 14, 2025
View reviewed changes
src/config/aiModels/minimax.ts Show resolved Hide resolved
src/config/modelProviders/minimax.ts Outdated Show resolved Hide resolved
@vercel Vercel
Copy link

vercel bot commented Jan 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-preview ❌ Failed (Inspect) Jan 15, 2025 1:49am

@arvinxx arvinxx merged commit da11b55 into lobehub:main Jan 15, 2025
6 of 8 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @hezhijie0327 ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献，感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣，请加入我们的 discord，然后私信 @arvinxx 或 @canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发，分享和讨论全球范围内的 AI 消息。

@hezhijie0327 hezhijie0327 deleted the minimax branch January 15, 2025 02:14
github-actions bot pushed a commit that referenced this pull request Jan 15, 2025
@semantic-release-bot
🔖 chore(release): v1.45.17 [skip ci]
d8da56f 
### [Version&nbsp;1.45.17](v1.45.16...v1.45.17)
<sup>Released on **2025-01-15**</sup>

#### ♻ Code Refactoring

- **misc**: Refactor Minimax with LobeOpenAICompatibleFactory.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Refactor Minimax with LobeOpenAICompatibleFactory, closes [#5325](#5325) ([da11b55](da11b55))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.45.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Jan 15, 2025
@semantic-release-bot
🔖 chore(release): v1.87.8 [skip ci]
ded9453 
### [Version&nbsp;1.87.8](v1.87.7...v1.87.8)
<sup>Released on **2025-01-15**</sup>

#### ♻ Code Refactoring

- **misc**: Refactor Minimax with LobeOpenAICompatibleFactory.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Refactor Minimax with LobeOpenAICompatibleFactory, closes [lobehub#5325](https://github.com/bentwnghk/lobe-chat/issues/5325) ([da11b55](da11b55))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
gecsp pushed a commit to gecsp/lobe-chat that referenced this pull request Jan 22, 2025
@hezhijie0327 @gecsp
♻️ refactor: refactor Minimax with LobeOpenAICompatibleFactory (lobeh…
b1825d1 
…ub#5325)

* ♻️ refactor: refactor Minimax with LobeOpenAICompatibleFactory

* 💄 style: add vision tag for `abab6.5s-chat` & `abab7-chat-preview`

* 🐛 fix: fix Minimax output long content interrupted by default `max_tokens` (256tokens)

* 💄 style: update aiModels list

* 🐛 fix: fix price typo

* 💄 style: add releaseAt tag
gecsp pushed a commit to gecsp/lobe-chat that referenced this pull request Jan 22, 2025
@semantic-release-bot @gecsp
🔖 chore(release): v1.45.17 [skip ci]
77c0e0d 
### [Version&nbsp;1.45.17](lobehub/lobe-chat@v1.45.16...v1.45.17)
<sup>Released on **2025-01-15**</sup>

#### ♻ Code Refactoring

- **misc**: Refactor Minimax with LobeOpenAICompatibleFactory.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Refactor Minimax with LobeOpenAICompatibleFactory, closes [lobehub#5325](lobehub#5325) ([da11b55](lobehub@da11b55))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvinxx arvinxx arvinxx left review comments

Assignees
No one assigned
Labels
released size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hezhijie0327 @lobehubbot @arvinxx