Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] 移动端话题界面右下侧出现无意义的 cancel/OK 按键 #5232

Closed
Sun-drenched opened this issue Dec 29, 2024 · 16 comments · Fixed by #5266
Closed

[Bug] 移动端话题界面右下侧出现无意义的 cancel/OK 按键 #5232

Sun-drenched opened this issue Dec 29, 2024 · 16 comments · Fixed by #5266
Labels
🐛 Bug Something isn't working | 缺陷 released

Comments

@Sun-drenched
Copy link

📦 部署环境

Docker

📌 软件版本

v1.42.1

💻 系统环境

iOS

🌐 浏览器

Safari

🐛 问题描述

如题、如图。这两个按键没有意义,话题栏左上侧已有关闭按键。点击 cancel 可关闭话题页面、点击 OK 无反应。
IMG_1646

📷 复现步骤

No response

🚦 期望结果

No response

📝 补充信息

No response

@Sun-drenched Sun-drenched added the 🐛 Bug Something isn't working | 缺陷 label Dec 29, 2024
@github-project-automation github-project-automation bot moved this to Roadmap - Chat 1.x in Lobe Chat Routine Dec 29, 2024
@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


📦 Deployment environment

Docker

📌 Software version

v1.42.1

💻 System environment

iOS

🌐 Browser

Safari

🐛 Problem description

Just like the title and picture. These two buttons are meaningless, and there is a close button on the upper left side of the topic bar. Click cancel to close the topic page, click OK but there will be no response.
IMG_1646

📷 Steps to reproduce

No response

🚦 Expected results

No response

📝 Supplementary information

No response

@lobehubbot
Copy link
Member

👀 @Sun-drenched

Thank you for raising an issue. We will investigate into the matter and get back to you as soon as possible.
Please make sure you have given us as much context as possible.
非常感谢您提交 issue。我们会尽快调查此事,并尽快回复您。 请确保您已经提供了尽可能多的背景信息。

Copy link

dosubot bot commented Dec 29, 2024

Hello @Sun-drenched! I'm here to assist you with any bugs, questions, or contributions you may have. Let's work together to resolve this issue.

The 'Cancel' and 'OK' buttons in the mobile topic interface of LobeChat are part of the Popconfirm component. The 'OK' button is intended to confirm actions like opening a new topic or saving current messages, depending on the context. However, if the 'OK' button has no effect when clicked, it might be due to conditional logic that checks for certain variables (editingProvider, id, and formInstance). If any of these are not defined, the button will not perform any action [1][2].

The 'Cancel' button is used to dismiss the confirmation dialog without taking any action [1]. If these buttons are deemed unnecessary, especially if there's already a close button in the interface, it might be worth considering a UI update to remove or repurpose them.

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other

@arvinxx
Copy link
Contributor

arvinxx commented Dec 30, 2024

咦…之前这个有吗

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Hey...did you have this before?

@Sun-drenched
Copy link
Author

咦…之前这个有吗

之前应该是没有的,但也无法确定从哪个版本开始出现的。

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Hey...Have you had this before?

It probably didn't exist before, but it's impossible to determine which version it started to appear in.

@sxjeru
Copy link
Contributor

sxjeru commented Dec 30, 2024

以前没有,近三天出现的吧。

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


It didn't happen before, but it appeared in the past three days.

@YANANEER
Copy link

就是最近这几个版本出现的,我有印象

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


These are the latest versions that have appeared, and I have the impression that

@hezhijie0327
Copy link
Contributor

hezhijie0327 commented Jan 1, 2025

一个个试了下 v1.40.4 后出现的 ,应该和 0533150 有关 降级到 "chroma-js": "^2.6.0" 后好像也有问题

v1.40.3 v1.40.4
image image

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


After trying v1.40.4 one by one, it should be related to 0533150

v1.40.3 v1.40.4
image ![image](https://github.com/user-attachments/assets/ d8a8b73a-3f4d-4fbd-8364-01935dfc8453)

@arvinxx
Copy link
Contributor

arvinxx commented Jan 1, 2025

@hezhijie0327 这个是组件的问题。 https://ui.lobehub.com/components/modal 统一了桌面和移动端的弹窗 button,但chat里没有对应更新掉。需要在chat 的这个话题弹窗组件里加个 footer={null} 的参数

@github-project-automation github-project-automation bot moved this from Roadmap - Chat 1.x to Done in Lobe Chat Routine Jan 2, 2025
@lobehubbot
Copy link
Member

@Sun-drenched

This issue is closed, If you have any questions, you can comment and reply.
此问题已经关闭。如果您有任何问题,可以留言并回复。

@lobehubbot
Copy link
Member

🎉 This issue has been resolved in version 1.42.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working | 缺陷 released
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants