From 617f84ec226e0d12e98d94675ecda413e3fbfdbd Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Fri, 17 Jan 2025 11:34:40 +0100 Subject: [PATCH] Revert "[libc++] Disable _LIBCPP_NODEBUG temporarily (#122393)" This reverts commit 24bf0e4eb63fe5eebf86f937ff41b66be78cf958. --- libcxx/include/__config | 4 +--- libcxx/test/tools/clang_tidy_checks/libcpp_module.cpp | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/libcxx/include/__config b/libcxx/include/__config index 658a7e16fae91..5d5c90d7b87a7 100644 --- a/libcxx/include/__config +++ b/libcxx/include/__config @@ -1166,9 +1166,7 @@ typedef __char32_t char32_t; # define _LIBCPP_NOESCAPE # endif -// FIXME: Expand this to [[__gnu__::__nodebug__]] again once the testcase reported in -// https://github.com/llvm/llvm-project/pull/118710 has been analyzed -# define _LIBCPP_NODEBUG +# define _LIBCPP_NODEBUG [[__gnu__::__nodebug__]] # if __has_attribute(__standalone_debug__) # define _LIBCPP_STANDALONE_DEBUG __attribute__((__standalone_debug__)) diff --git a/libcxx/test/tools/clang_tidy_checks/libcpp_module.cpp b/libcxx/test/tools/clang_tidy_checks/libcpp_module.cpp index f49f3e3c615ca..bc7c8ce7ec443 100644 --- a/libcxx/test/tools/clang_tidy_checks/libcpp_module.cpp +++ b/libcxx/test/tools/clang_tidy_checks/libcpp_module.cpp @@ -27,7 +27,7 @@ class LibcxxTestModule : public clang::tidy::ClangTidyModule { check_factories.registerCheck("libcpp-header-exportable-declarations"); check_factories.registerCheck("libcpp-hide-from-abi"); check_factories.registerCheck("libcpp-internal-ftms"); - // check_factories.registerCheck("libcpp-nodebug-on-aliases"); + check_factories.registerCheck("libcpp-nodebug-on-aliases"); check_factories.registerCheck("libcpp-cpp-version-check"); check_factories.registerCheck("libcpp-robust-against-adl"); check_factories.registerCheck("libcpp-uglify-attributes");