add_spp for RRTMG #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@bluefinweiwei, it looks like two swap files were included in this PR by accident. Can you push a commit to remove them? Thanks!
|
@JeffBeck-NOAA The two .swp removed - always hard to notice these hidden files. Thanks for catching them! |
climbfuji
requested changes
Jun 25, 2021
bluefinweiwei
force-pushed
the
add_spp
branch
2 times, most recently
from
83387a9 to
432a77d
Compare
modified: mp_thompson.F90
llpcarson
pushed a commit
that referenced
this pull request
Sep 7, 2021
Constants update from main 2021/08/10
llpcarson
pushed a commit
that referenced
this pull request
Sep 7, 2021
redund_mzhang update Dom 2021/08/16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@llpcarson @JeffBeck-NOAA
Added spp to RRTMG radiation scheme in CCPP. Compiled successfully and currently being tested using UFS SRW.
Issue needs a special review: As in WRF, we are subtracting the variable pattern_spp with a dimension of (im, levs) to effective radii of cloud/ice/snow variables with a dimension of (im, lm). As you know, in CCPP, “levs” is “vertical_dimension" and “lm” is “number_of_vertical_layers_for_radiation_calculation”, so we end it up with incompatible dimensions to do arithmetic operation… The code is updated by assuming the overlapping layers between lm and levs are the same and putting a IF statement to separate (lm < levs) or (lm >=levs) scenarios. If (lm >=levs), for layers above "levs", the perturbation patterns are all treated as equal to pattern_spp (i, levs).
modified: physics/GFS_rrtmg_pre.F90
modified: physics/GFS_rrtmg_pre.meta