Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Your minified version is bad #16

Open
CollinChaffin opened this issue Sep 16, 2019 · 1 comment
Open

Your minified version is bad #16

CollinChaffin opened this issue Sep 16, 2019 · 1 comment

Comments

@CollinChaffin
Copy link

Your minified version changes all query tr to white removing the required red/green and appears to not be minified with new lines added at the start for some reason. Your non-min version I believe when I diffed from forks doesn't even contain the offending tr.odd tr.even, so not sure if you even intended them to be there?

@lkd70
Copy link
Owner

lkd70 commented Sep 24, 2019

Please check my last commit, it explains why this is. It is an ugly patch but is needed due to the pihole team using inline css for several elements (Including the colour grading).

I plan to make pull requests to change that in the future, but my time is limited at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants