Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input value not rendering when value is a an empty string #6

Open
chrisabrams opened this issue May 8, 2016 · 3 comments
Open

Input value not rendering when value is a an empty string #6

chrisabrams opened this issue May 8, 2016 · 3 comments

Comments

@chrisabrams
Copy link

chrisabrams commented May 8, 2016

If there is an input such as:

<input id="foo" value="#{inputValue}" />

If the reducer returns

{inputValue: 'foo'}

then the input correctly renders with 'foo' as the value.

However, if the reducer returns

{inputValue: ''}

then the input will display '#{inputValue}' as the value, as if it was just skipped to be rendered all together.

TLDR: input values should be able to receive blank strings (because sometimes we don't know if we want to display a blank input or an input with a value)

@chrisabrams
Copy link
Author

Do you think this is at all related to google/incremental-dom#239

@jwerle
Copy link
Contributor

jwerle commented May 10, 2016

Hmm that could be causing it. It is interesting that you are actually getting #{inputValue} as the value. That means the template string is being interpolated...

@chrisabrams
Copy link
Author

Yep, I dunno what's going on :O

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants